thh/newsstats
1
0
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Activity

Compare commits

base: thh:9a4873e00ede4ee1129cdb0a4abdc28c30a7628d
Branches Tags
thh:master
thh:next
thh:0.4.0
thh:0.3.0
thh:0.2.0
thh:0.01
...
compare: thh:f3b184f2e315a5c9c89da09c3ff3434fffc639f4
Branches Tags
thh:next
thh:master
thh:0.4.0
thh:0.3.0
thh:0.2.0
thh:0.01

2 commits
9a4873e00e ... f3b184f2e3

Author SHA1 Message Date
Thomas Hochstein
f3b184f2e3 gatherstats: Don't' overwrite User-Agent with X-Newsreader. 
Signed-off-by: Thomas Hochstein <thh@thh.name>
 2026-01-17 03:01:54 +01:00
Thomas Hochstein
deb812da58 FormatOutput(): Add missing variable init. 
Signed-off-by: Thomas Hochstein <thh@thh.name>
 2026-01-17 03:01:31 +01:00
3 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
bin/gatherstats.pl
View file

@ -411,8 +411,8 @@ sub ClientStats {
# parse header # parse header
# User-Agent style # User-Agent style
if ($Header{'x-newsreader'} =~ /^([^\/ ]+\/[^\/ ]+ ?)+$/) { if ($Header{'x-newsreader'} =~ /^([^\/ ]+\/[^\/ ]+ ?)+$/) {
# transfer to user-agent and parse from there # transfer to user-agent, if not set, and parse from there
$Header{'user-agent'} = $Header{'x-newsreader'}; $Header{'user-agent'} = $Header{'x-newsreader'} if !$Header{'user-agent'};
# "client name version" # "client name version"
} elsif ($Header{'x-newsreader'} =~ / /) { } elsif ($Header{'x-newsreader'} =~ / /) {
($Client, $Version) = ParseXNewsreader($Header{'x-newsreader'}); ($Client, $Version) = ParseXNewsreader($Header{'x-newsreader'});
@ -428,7 +428,7 @@ sub ClientStats {
version => $Version); version => $Version);
push @Clients, { %UserAgent }; push @Clients, { %UserAgent };
} else { } else {
$Header{'user-agent'} = $Header{'x-newsreader'}; $Header{'user-agent'} = $Header{'x-newsreader'} if !$Header{'user-agent'};
} }
} }
### User-Agent ### User-Agent

2
doc/ChangeLog
View file

@ -5,6 +5,8 @@ NewsStats 0.5.0 (unreleased)
* Add addpost (to add post data dropped by feedlog). * Add addpost (to add post data dropped by feedlog).
* Rename postingstats.pl to poststats.pl, rename * Rename postingstats.pl to poststats.pl, rename
dopostingstats.sh accordingly, fix all references. dopostingstats.sh accordingly, fix all references.
* Fix missing variable initialisation in FormatOutput().
* gatherstats: Don't' overwrite User-Agent with X-Newsreader.
NewsStats 0.4.0 (2025-06-02) NewsStats 0.4.0 (2025-06-02)
* Reformat $Conf{TLH} for GroupStats only. * Reformat $Conf{TLH} for GroupStats only.

3
lib/NewsStats.pm
View file

@ -501,6 +501,9 @@ sub FormatOutput {
my ($Format, $Comments, $LeadIn, $Caption, $Key, $Value, $Precision, $PadField, my ($Format, $Comments, $LeadIn, $Caption, $Key, $Value, $Precision, $PadField,
$PadValue, $LastIteration) = @_; $PadValue, $LastIteration) = @_;
my ($Output); my ($Output);
# initialise $PadValue; $PadField needs not to be initialised,
# as access to both is gated by valid $PadField
$PadValue = 0 if !$PadValue;
# create one line of output # create one line of output
if ($Format eq 'dump') { if ($Format eq 'dump') {
# output as dump (key value) # output as dump (key value)