thh/usevote
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Activity

Non-greedy matching for votestrings.

Browse source 
A single choice on a ballot has this format:

 #1   [            ]  This or that

The regexp in uvvote.pl's process_vote() will
match and extract what's beetwen "[" and "]".
But if "This or that" contains a "]", the
match will be too greedy:

 #1   [            ]  This [or that]
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ <- match

Fix that by using a non-greedy operator.

Signed-off-by: Thomas Hochstein <thh@thh.name>
This commit is contained in:
Thomas Hochstein 2022-03-29 22:56:47 +02:00
parent f90cfdb57f
commit a7ea02d592
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
uvvote.pl
View file

@ -271,7 +271,7 @@ sub process_vote {
} }
# this matches on a single appearance: # this matches on a single appearance:
if ($$body =~ /#$votenum\W*?\[(.+)\]/) { if ($$body =~ /#$votenum\W*?\[(.+?)\]/) {
# one or more vote strings were found # one or more vote strings were found
$onevote ||= 1; # set $onevote to 1 if it was 0 $onevote ||= 1; # set $onevote to 1 if it was 0
my $votestring = $1; my $votestring = $1;